Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix excessive cpu consumption #92

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fix excessive cpu consumption #92

merged 2 commits into from
Nov 6, 2024

Conversation

Zaakhi
Copy link
Contributor

@Zaakhi Zaakhi commented Nov 5, 2024 •
edited
Loading

This pull request Fixes issue #91

The issue is caused by the self._state_cb where is going at the same rate of the Controller Manager.

To solve this, the subscriber is created and destroyed every time the action is called using wait_for_message rlcpy function.

Before the fix:
cpu_consumption

After the fix:
cpu_consumption_solved

fixes #91

bmagyar
bmagyar approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up! Which distro would you like this in?

@bmagyar bmagyar requested a review from Noel215 November 5, 2024 18:15
@bmagyar
Copy link
Member

bmagyar commented Nov 5, 2024

@Noel215 if you are also happy please merge

@Zaakhi
Copy link
Contributor Author

Zaakhi commented Nov 6, 2024

Thanks for following up! Which distro would you like this in?

For now it's humble, thank you very much!

@Noel215 Noel215 merged commit 6ff23a3 into ros-teleop:master Nov 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

@Noel215 Noel215 Noel215 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CPU consumption in the incrementer_server node is too high
3 participants
@Zaakhi @bmagyar @Noel215